Conversation
Notices
-
@johnnynull @kevingranade And done. Highlighting, striping, and reply highlighting are now done with overlays and faces will merge properly.
-
@johnnynull found the reply-to-all bug. Highlighting a reply overwrites the text properties that reply-to-all uses to find usernames.
-
@johnnynull you may notice that usernames within replies (like this one!) aren't underlined, this is the root of the problem.
-
@johnnynull there's a dirty fix where I use a regex to find usernames, and a clean one where I fix highlighting in general.
-
@johnnynull the key functions are identica-render-timeline and identica-status-to-status-datum, the problem is text property handling.
-
@johnnynull a character can only have one "face" attached to it, so when I add the "reply" face it removes the "username" face.
-
@johnnynull I'm redoing highlighting by using "overlays" for them instead of attaching the properties to the characters themselves.
-
All Identi.ca content and data are available under the