Hm, I don't think that's true. While solitary confinement is sometimes used (wrongly) for "protection" for a suicide risk, even with that aside, as you said, it doesn't make sense to make this indefinite. And Manning has been punished for previously having a partial tube of toothpaste as well as "the wrong books" and etc. So I get what you're saying, yes this is often a procedure incorrectly used, I think it's important to make clear this isn't at all for the "protection" of Manning.
I agree, just that the usage of "punished for attempting suicide" was a bit jarring. Of course they jumped on the first option they got to kick Manning some more, but they covered their asses pretty well. Using that punished rhetoric plays to their hands.