One bad news, two good news
Dear pump.io friends
The bad news is that my fix for issue #458 ("You likes") does not work.
The good news #1 is that I managed to setup a pump.io instance for testing purposes, and I tested my fix (and realised that it does not work), and figure out how to really fix that issue.
So the question is, What do I do now? Do I close that branch and pull request and create a new one? Or do I commit my fixes and that's all?
In any case history is messed up (wether in commit log or in issue tracker).
The good news #2 is that for now on I'll test my fixes before than creating a pull request.
Sorry for the inconveniences until now.
Dear pump.io friends
The bad news is that my fix for issue #458 ("You likes") does not work.
The good news #1 is that I managed to setup a pump.io instance for testing purposes, and I tested my fix (and realised that it does not work), and figure out how to really fix that issue.
So the question is, What do I do now? Do I close that branch and pull request and create a new one? Or do I commit my fixes and that's all?
In any case history is messed up (wether in commit log or in issue tracker).
The good news #2 is that for now on I'll test my fixes before than creating a pull request.
Sorry for the inconveniences until now.
mray INACTIVE, libre likes this.
Thanks for all your efforts
Ok, I've commited changes and I think now it works.
Animo Laura y felicitaciones por tu iniciativa
I don't think history is messed up. Did your fix merge onto master branch? Only in that case, it is advisable to revert the failed commit, then commit the working fix. Otherwise, unmerged branches are mostly ignored (i.e. not visible in master log.) But I am not a github user.